Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDEA] Fix solenoid for o1_v03 #335

Merged
merged 2 commits into from
May 30, 2024
Merged

[IDEA] Fix solenoid for o1_v03 #335

merged 2 commits into from
May 30, 2024

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented May 17, 2024

BEGINRELEASENOTES

  • Fix for the IDEA_o1_v03 solenoid position

ENDRELEASENOTES

@BrieucF BrieucF mentioned this pull request May 28, 2024
Closed
5 tasks
@BrieucF
Copy link
Contributor Author

BrieucF commented May 29, 2024

@andresailer can we merge this?

@andresailer
Copy link
Contributor

This is changing XML parameters for a detector that I have no expertise in nor responsibility for. So unless you have some specific concern I should comment on, don't wait for me in these cases.

@BrieucF BrieucF merged commit e5d641a into key4hep:main May 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrieucF @andresailer