Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FCCDetectorsMigration] Noble liquid ecal barrel #276

Merged
merged 2 commits into from
Jun 20, 2023
Merged

[FCCDetectorsMigration] Noble liquid ecal barrel #276

merged 2 commits into from
Jun 20, 2023

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Jun 13, 2023

BEGINRELEASENOTES

  • Migrate the noble liquid ECAL barrel C++ builder from FCCDetectors together with its documentation
    ENDRELEASENOTES

@jmcarcell
Copy link
Member

Looks good, some tests fail due to a missing xerces library but they are unrelated to this PR, merging so that people can use this. The cpp file has not beed added to any CMakeLists.txt but this is known by the authors (will be added later after more files are migrated)

@jmcarcell jmcarcell merged commit d6674f1 into key4hep:master Jun 20, 2023
@BrieucF BrieucF mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrieucF @jmcarcell