Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tpcsd2 #263

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Update tpcsd2 #263

merged 2 commits into from
Jan 13, 2023

Conversation

danieljeans
Copy link
Contributor

BEGINRELEASENOTES

  • deal with case when previousStep is not yet defined (could cause crash)
  • add timing information to the lowPt hits
    ENDRELEASENOTES

@danieljeans danieljeans mentioned this pull request Jan 13, 2023
Closed
@danieljeans
Copy link
Contributor Author

cleaned up version of #262

@tmadlener tmadlener merged commit a8bcaa5 into key4hep:master Jan 13, 2023
jmcarcell added a commit that referenced this pull request Mar 8, 2023
@jmcarcell
syncing downstream-build.yaml; previous commit: Author: Daniel Jeans …
47b8dc5 
…<daniel.jeans@kek.jp>

Date:   Fri Jan 13 17:16:26 2023 +0900

    Update tpcsd2 (#263)

    * deal with case of undefined previousStep

    * add time information to LowPt hits
BrieucF pushed a commit to BrieucF/k4geo that referenced this pull request Jun 13, 2023
@danieljeans @BrieucF
Update tpcsd2 (key4hep#263)
ccaed1e 
* deal with case of undefined previousStep

* add time information to LowPt hits
BrieucF pushed a commit to BrieucF/k4geo that referenced this pull request Jun 13, 2023
@jmcarcell @BrieucF
syncing downstream-build.yaml; previous commit: Author: Daniel Jeans …
d828d0e 
…<daniel.jeans@kek.jp>

Date:   Fri Jan 13 17:16:26 2023 +0900

    Update tpcsd2 (key4hep#263)

    * deal with case of undefined previousStep

    * add time information to LowPt hits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljeans @tmadlener