Propagate CollectionBuffer changes from https://github.com/AIDASoft/podio/pull/197 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolkl
force-pushed
the
ref-collections
branch
from
2a1883b to
67d5197
Compare
vvolkl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Currently, these are only the minimal syntax changes. Since the PodioDataSvc does not use the ROOTWriter at the moment (due to the I/O of basic types not supported yet) either the changes from AIDASoft/podio#197 must be ported here, or we wait for
AIDASoft/podio#213 and then refactor to use the ROOTWriter.
I prefer the second option (also because simply adding the ROOTWriter changes here still produced a segfault that would need to be debugged).