Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vCard: Parse multiple types #343

Closed
Henni opened this issue Oct 31, 2017 · 4 comments · Fixed by #388
Closed

vCard: Parse multiple types #343

Henni opened this issue Oct 31, 2017 · 4 comments · Fixed by #388

Comments

@Henni
Copy link

Henni commented Oct 31, 2017

These type parameter values can be specified as a parameter list (e.g., TYPE=text;TYPE=voice) or as a value list (e.g., TYPE="text,voice").

https://tools.ietf.org/html/rfc6350#section-6.4.1

Expected behaviour

TEL;VALUE=uri;TYPE=work;TYPE=voice:tel:+33-89-01-23-45

should be parsed to:

[ "tel", { "type": ["work", "voice"] }, "uri", "tel:+33-89-01-23-45" ],

Actual behaviour

The param value is set to the last occurring value:

[ "tel", { "type": "voice" }, "uri", "tel:+33-89-01-23-45" ],

I modified a vcard parser test to display the issue:
https://github.com/Henni/ical.js/commit/6d4365e374a12a20d4433f6f6a4186baafa126c3

@skjnldsv
Copy link

skjnldsv commented Feb 19, 2019

@mschroeder @kewisch any news from this one? This quite an important part of the rfc :)
Is it a difficult fix?

@torrentkino
Copy link

Is there progress already?

@Aa88s
Copy link

Aa88s commented Nov 2, 2019

(Type=text;Type=voice)

@skjnldsv
Copy link

skjnldsv commented Nov 2, 2019

@torrentkino yes a pr is here #388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants