Don't use arrow functions and const to work on IE11 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumewuip
changed the title
AndyCErnst
reviewed
Jun 8, 2020
| @@ -2,21 +2,21 @@ | |||
| const ipRegex = require('ip-regex'); | |||
| const tlds = require('tlds'); | |||
|
|
|||
| module.exports = options => { | |||
| module.exports = function(options) { | |||
| options = { | |||
| strict: true, | |||
| ...options | |||
There was a problem hiding this comment.
the spread operate breaks in IE11 as well though so that needs to be swapped out
|
I feel like this won't be needed since this PR needs to be compiled either way to use |
|
This issue is fixed in my maintained and modern version of this package at https://github.com/niftylettuce/url-regex-safe. You should be able to switch from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library cannot be used out-of-the-box on IE11 because IE6 is not supported there.
This PR simply convert the two arrow functions into classic
functions and replaceconstbyvar