Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unnecessary Docker Test Pipeline #93

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Remove Unnecessary Docker Test Pipeline #93

merged 4 commits into from
Jul 31, 2024

Conversation

kevinthedang
Copy link
Owner

Changes

  • Removed the Discord-Ollama-Container-Test pipeline on Pull Request as it is not necessary and is a duplicate of the Discord-Node-Test pipeline.
  • Allowed for build.yml to depend on the Test pipelines to complete as if they do not work then the builds will not properly execute.

@kevinthedang kevinthedang added CI/CD Integration and Deployment technical Non-business related labels Jul 31, 2024
@kevinthedang kevinthedang self-assigned this Jul 31, 2024
@kevinthedang kevinthedang linked an issue Jul 31, 2024 that may be closed by this pull request
Docker Unit Test Pipeline runs detached and may no longer be needed #92
Closed
@kevinthedang
Copy link
Owner Author

With how workflow_run: works, the build pipelines can only be run on the default branch... kinda sucks but it is fine I guess.

With this anyway it will help segway into: PR -> Test -> Build -> Deploy
So, this seems to be fine with me.

JT2M0L3Y
JT2M0L3Y approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@JT2M0L3Y JT2M0L3Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I suppose one way we can clean up the scripts in the package is to remove the processes that use them if not necessary.
Good idea!

@kevinthedang kevinthedang merged commit 02ffb6a into master Jul 31, 2024
1 check passed
@kevinthedang kevinthedang deleted the remove-docker-test-pipeline branch July 31, 2024 13:21
@kevinthedang kevinthedang mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JT2M0L3Y JT2M0L3Y JT2M0L3Y approved these changes

Assignees

@kevinthedang kevinthedang

Labels
CI/CD Integration and Deployment technical Non-business related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker Unit Test Pipeline runs detached and may no longer be needed
2 participants
@kevinthedang @JT2M0L3Y