Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use urlopen context manager to handle connection close in a timely manner #47

Closed
wants to merge 1 commit into from
Closed

use urlopen context manager to handle connection close in a timely manner #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/pan/xapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def __get_header(self, response, name):
return types

def __set_response(self, response):
message_body = response.read()
message_body = response.body

content_type = self.__get_header(response, 'content-type')
if not content_type:
Expand Down Expand Up @@ -542,7 +542,11 @@ def __api_request(self, query):
kwargs['timeout'] = self.timeout

try:
response = urlopen(**kwargs)
response = None
with urlopen(**kwargs) as r:
response = r
response.body = r.read()


# XXX handle httplib.BadStatusLine when http to port 443
except self._certificateerror as e:
Expand Down