Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Closeable to AutoCloseable #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garcia-jj
Copy link
Contributor

Sorry for my previously commit. AutoCloseable is the right interface to inherit BeanWriter and BeanReader`.

@garcia-jj
Copy link
Contributor Author

@kevinseim Can we merge this pull request? Thank you.

@bjansen
Copy link

bjansen commented Mar 11, 2021

@garcia-jj could you open the same PR at https://github.com/beanio/beanio? I'll merge it with pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants