Declare minimum supported rust version as 1.74, and test this in CI #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minimum is imposed by the use of OsStr::as_encoded_bytes in platform/linux_usbfs/enumeration.rs.
|
Thanks! Looking forward to getting my Cynthion and trying Packetry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
nusbdoes not specify a minimum supported Rust version (MSRV). This information would be useful to have.In the process of trying to minimise the MSRV for a downstream project, I found that nusb's MSRV is currently 1.74.
This PR declares that MSRV, and updates CI to test with both the MSRV and the latest stable release, to give a warning if the minimum becomes inaccurate.
It might be possible to reduce the MSRV, if that's of interest.
During testing I found that older releases such as 0.1.3 could be built with Rust 1.64.
Use of
Option::is_some_andraised the requirement to 1.70.Use of
OsStr::as_encoded_bytesraised the requirement to 1.74.