Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid empty prompts #124

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

pd95
Copy link
Contributor

@pd95 pd95 commented Feb 3, 2025

As described in #123, empty prompts are irritating and should not be send to the model.

This change adds check to avoid empty prompts and pre-processes the prompt trimming whitespaces from the string before seeing it to the model.

pd95 added 2 commits February 3, 2025 18:46
- Disable `CircleButton` on empty prompt
- Abort `generateAction` if prompt is empty
@kevinhermawan
Copy link
Owner

Thanks! 😁

@kevinhermawan kevinhermawan merged commit b399ec0 into kevinhermawan:main Feb 3, 2025
@pd95 pd95 deleted the fix/avoid-empty-prompt branch February 3, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants