Add the possibility to ignore the Match directive #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2024
Open
quike
approved these changes
Jul 17, 2024
quite
reviewed
Jul 17, 2024
quite
approved these changes
Jul 17, 2024
quike
approved these changes
Jul 17, 2024
|
@kevinburke could you take a look whenever you have a chance? thanks |
|
We can't even use the go mode we can't override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make #6 less of an issue.
The
go-git-v5lib uses your nice ssh parser however in Alma 8/9 and most of RHEL there is thisMatchdirective in the default ssh config and it completely breaks all the git operation in these OSesWhile someone brave enough makes the implementation for parsing the Match I thought ignoring it would be enough.
Ideally we shouldn't be passing so many params to functions but I didn't want to refactor to much stuff.
After this PR is merged you could ignore the directive like this:
ssh_config.DefaultUserSettings.IgnoreMatchDirective = trueThis