Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added delete apis #28

Merged
merged 2 commits into from
Dec 19, 2023
Merged

added delete apis #28

merged 2 commits into from
Dec 19, 2023

Conversation

ankit-pn
Copy link
Contributor

restructured the database package - removed addDoc.go and addImage.go and included doc.go and image.go, these two file should contain logic of every database operation.

renamed handleDocsUpload.go to handleDocUpload.go - since we are dealing with 1 file at a time, it is better to keep doc instead of docs

modified - api.go to include delete endpoint

added HandleImageDelete and HandleDocDelete Method to deal with deletion

restructure database package files
renamed:    database/addDoc.go -> database/doc.go
renamed:    database/addImage.go -> database/image.go
modified:   router/api.go - added routes for delete api
renamed:    util/handlers/docs/handleDocsUpload.go -> util/handlers/docs/handleDocUpload.go
Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: 9f73c36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kevinanielsen
Copy link
Owner

Just tested it on my machine and everything runs perfectly - Thanks for your contribution!
If you want to contribute again that would be great!
Please try doing it in more commits next time though :)

@kevinanielsen kevinanielsen merged commit f722ec9 into kevinanielsen:main Dec 19, 2023
@ankit-pn
Copy link
Contributor Author

This looks like a very interesting project to me. I would love to contribute again to this project, it would be great to add some more enhancement issues to this project, maybe we can try adding some milestone like implementing edge server for cdn and implementing a caching mechanism to it.

Anyway thanks.

@kevinanielsen
Copy link
Owner

@ankit-pn Sounds like fun features - I am definitely open to ideas, the most important thing for me is that it needs to be easy to use, and easy to host!

@ankit-pn
Copy link
Contributor Author

Ok thanks, maybe I will add some features/ suggestions at issues in future. We will discuss it and if it sounds good then try to implement it.

@kevinanielsen
Copy link
Owner

@ankit-pn Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants