Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rule B (flake8-bugbear) on ruff #729

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Enable rule B (flake8-bugbear) on ruff #729

merged 1 commit into from
Jun 27, 2023

Conversation

jairhenrique
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jairhenrique, I'm having some trouble with these:

with pytest.raises(Exception): # noqa B017

Wouldn't it be better to replace Exception by a to-the-point exception here, i.e. fixing what B017 considers evil?

Copy link
Collaborator

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jairhenrique thanks for the adjustments! 👍

@jairhenrique jairhenrique merged commit 4f70152 into master Jun 27, 2023
6 checks passed
@jairhenrique jairhenrique deleted the bugbear branch June 28, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants