Integrate vcrpy-unittest (alternative to #709) #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
force-pushed
the
integrate-vcrpy-unittest
branch
from
8fb50cd
to
a145150
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 89.78% 90.40% +0.61%
==========================================
Files 27 28 +1
Lines 1743 1772 +29
Branches 243 313 +70
==========================================
+ Hits 1565 1602 +37
+ Misses 143 135 -8
Partials 35 35
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hartwork
force-pushed
the
integrate-vcrpy-unittest
branch
from
a145150
to
4e0d272
Compare
jairhenrique
reviewed
Jun 2, 2023
agriffis
reviewed
Jun 2, 2023
|
one small doc comment, otherwise looks fine to me at a glance. I haven't used this in a number of years, so I won't be testing it. |
jairhenrique
approved these changes
Jun 2, 2023
Source commit is a2fd7625fde1ea15c8982759b07007aef40424b3. License is MIT just like vcrpy.
.. to resolve import ambiguity.
Matcher needs attribute __name__ for function vcr.matchers.get_matchers_results .
.. for Python 3
.. and make "from vcr.unittest import VCRTestCase" work again.
hartwork
force-pushed
the
integrate-vcrpy-unittest
branch
from
1147abe
to
d613a81
Compare
|
@kevin1024 I believe this pull request is ready fro prime time. Any concerns left about merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #709