Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishToGitHubPages fails if you have greater than 30 branches alphabetically before gh-pages. #119

Closed
zarthross opened this issue Nov 19, 2021 · 5 comments · Fixed by #120
Assignees
Labels
bug Something isn't working
Milestone

Comments

@zarthross
Copy link

Very similar to #113 I get an error that gh-pages does not exist... problem is it does. The github api repo list endpoint has a default page size of 30 and the code https://github.com/Kevin-Lee/sbt-github-pages/blob/32477dce3a8ab7a965db1dc920bfb8e0dc9ba16d/src/main/scala/githubpages/github/GitHubApi.scala#L330-L339 appears to take exactly 1 page, of the default size.

@kevin-lee
Copy link
Owner

@zarthross Thanks Darren for reporting this bug and you also found the cause! That's great! I really appreciate. 🙂 👍
I'm on it!

@kevin-lee kevin-lee added the bug Something isn't working label Nov 20, 2021
@kevin-lee kevin-lee modified the milestones: milestone11, milestone12 Nov 20, 2021
@kevin-lee
Copy link
Owner

@zarthross OK, I've fixed it. I'll release it shortly.

@zarthross
Copy link
Author

Awesome, @kevin-lee thanks for the quick work!

kevin-lee added a commit that referenced this issue Nov 20, 2021
kevin-lee added a commit that referenced this issue Nov 20, 2021
…tection

Fix #119 - `publishToGitHubPages` fails if you have greater than 30 branches alphabetically before `gh-pages`
@kevin-lee
Copy link
Owner

@zarthross Not at all. Your bug report was a lot more valuable as you found the cause which saved my time a lot!

It's been released. https://github.com/Kevin-Lee/sbt-github-pages/releases/tag/v0.8.1
It's already available on the Maven Central.

@zarthross
Copy link
Author

Awesome, thanks again!

@kevin-lee kevin-lee self-assigned this May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants