-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add STRING input validator #1123
Conversation
4d3da45
to
e36a10d
Compare
e36a10d
to
b6cd868
Compare
@yuri1969 thanks for your PR. I update it to allow more flexible validation by allowing to validate all input types with differents validation properties and enabling the UI to be aware of this validation. |
@loicmathieu Great, adding type-specific validation implementations should be easy now. |
b6cd868
to
b88fb42
Compare
I rebased the branch onto master as there was a strange test error. We will discuss internally if we merge this one as is or if we take the opportunity to add more constraints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change for seems to be good stuff anyway and there is missing change on webserver unit test
core/src/test/java/io/kestra/core/serializers/YamlFlowParserTest.java
Outdated
Show resolved
Hide resolved
48b3504
to
e1b5255
Compare
41e0ce3
to
5b28dc1
Compare
e1b5255
to
b495260
Compare
@yuri1969 thanks a lot for your contribution, it is now merged and will be included in Kestra 0.9.0 ! I created two issue to continue on the subject to have a complete input validation in Kestra. |
This PR adds a regex-based validation for the
STRING
inputs. The pattern is defined byinput
's newly addedvalidator
property.This PR deals with the STRING inputs only since these are frequent & variable.
Naming, etc. should be reviewed to fit in.
close #1122