Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception on the worker hiding probably the true error #7548

Closed
tchiotludo opened this issue Feb 25, 2025 · 2 comments · Fixed by #7585
Closed

Exception on the worker hiding probably the true error #7548

tchiotludo opened this issue Feb 25, 2025 · 2 comments · Fixed by #7585
Assignees
@nkwiatkowski
Labels
area/backend Needs backend code changes bug Something isn't working kind/backport-needed Issue that needs to be backported to a previous version kind/customer-request Requested by one or more customers

Comments

@tchiotludo
Copy link
Member

tchiotludo commented Feb 25, 2025 •
edited by anna-geller
Loading

2025-02-25 18:15:31,245 [34mINFO [0;39m [35mworker_0 [0;39m [36mf.dma.myariabd_test.get_last_date[0;39m [tenant: dst_dev] [namespace: dma] [flow: dma.myariabd_test] [task: get_last_date] [execution: eVk7OY7ICuc7rsozkuCtY] [taskrun: 2JEGs7ySioHMpIWeI93EwY] Type Query with state RUNNING completed in 00:00:00.876 2025-02-25 18:15:31,245 [1;31mERROR[0;39m [35mworker_0 [0;39m [36m.c.u.ThreadUncaughtExceptionHandlers[0;39m Caught an exception in Thread[#139,worker_0,5,main]. Shutting down. java.lang.NullPointerException: Cannot invoke "io.kestra.core.runners.RunContextLogger.resetMDC()" because "this.logger" is null at io.kestra.core.runners.DefaultRunContext.cleanup(DefaultRunContext.java:478) at io.kestra.core.runners.Worker.run(Worker.java:698) at io.kestra.core.runners.Worker.handleTask(Worker.java:332) at io.kestra.core.runners.Worker.lambda$run$8(Worker.java:261) at io.micrometer.core.instrument.internal.TimedRunnable.run(TimedRunnable.java:49) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) at java.base/java.lang.Thread.run(Thread.java:1583) 2025-02-25 18:15:32,365 [34mINFO [0;39m [35mworker_0 [0;39m [36mio.kestra.core.runners.Worker[0;39m All working threads are terminated.
I don't have any more information, I think the true exception is hidden behind this one
@tchiotludo tchiotludo added bug Something isn't working area/backend Needs backend code changes labels Feb 25, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 25, 2025
@tchiotludo tchiotludo added kind/backport-needed Issue that needs to be backported to a previous version kind/customer-request Requested by one or more customers labels Feb 25, 2025
@nkwiatkowski nkwiatkowski moved this from Backlog to In progress in Issues Feb 26, 2025
@anna-geller
Copy link
Member

adding clearer exceptions here will help solve https://github.com/kestra-io/kestra-ee/issues/2977

because for now we only get this exception: java.sql.SQLException: No suitable driver found for

nkwiatkowski pushed a commit that referenced this issue Feb 26, 2025
fix(#7548): NPE on runContext cleanup if logger is null
2c7b583
nkwiatkowski pushed a commit that referenced this issue Feb 26, 2025
clean(#7548): unused import
bd3def6
@nkwiatkowski nkwiatkowski mentioned this issue Feb 26, 2025
Merged
nkwiatkowski added a commit that referenced this issue Feb 26, 2025
@nkwiatkowski
Feat/npe on runcontext cleanup (#7585)
d8e3a9a 
* fix(#7548): NPE on runContext cleanup if logger is null

* clean(#7548): unused import

---------

Co-authored-by: nKwiatkowski <nkwiatkowski@kestra.io>
@github-project-automation github-project-automation bot moved this from In progress to Done in Issues Feb 26, 2025
nkwiatkowski added a commit that referenced this issue Feb 26, 2025
@nkwiatkowski
Feat/npe on runcontext cleanup (#7585)
09d5b2f 
* fix(#7548): NPE on runContext cleanup if logger is null

* clean(#7548): unused import

---------

Co-authored-by: nKwiatkowski <nkwiatkowski@kestra.io>
@nkwiatkowski
Copy link
Contributor

done and backported to release 0.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkwiatkowski nkwiatkowski

Labels
area/backend Needs backend code changes bug Something isn't working kind/backport-needed Issue that needs to be backported to a previous version kind/customer-request Requested by one or more customers
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/npe on runcontext cleanup kestra-io/kestra
3 participants
@tchiotludo @nkwiatkowski @anna-geller