Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable software LED control of port LEDs #729

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Disable software LED control of port LEDs #729

merged 3 commits into from
Oct 18, 2024

Conversation

troglobit
Copy link
Contributor

Description

This PR disables software control of port LEDs, for details, see #670

Also in this PR, a backport of a Finit patch to reduce the impact of reloading (SIGHUP) services like syslogd, which many other services in Infix depend of (as a barrier). The patch makes sure a HUP-capable service (A) do not trigger reload/restart of other services that depend on A.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix, or mitigation
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For details, see discussion in #670

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This patch fixes a upstream issue troglobit/finit#415, greatly reducing
the amount of service restarts, needlessly affecting, e.g., iitod when
services like syslogd¹ is reloaded.

____
¹) Traditional UNIX services that properly support SIGHUP.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit added the ci:main Build default defconfig, not minimal label Oct 17, 2024
@troglobit troglobit added this to the Infix v24.10 milestone Oct 17, 2024
@troglobit troglobit requested a review from wkz October 17, 2024 14:32
@troglobit troglobit self-assigned this Oct 17, 2024
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squeaky clean! ✨

@wkz wkz merged commit eac60b1 into main Oct 18, 2024
6 checks passed
@wkz wkz deleted the led-fixes branch October 18, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:main Build default defconfig, not minimal
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants