yanger: hide internal interfaces #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run ip link and ip addr once and handle the interface selection in Yanger. This should be faster on systems with many ports and it simplifies the CLI test files. Signed-off-by: Richard Alpe <richard@bit42.se>
Yanger now has the ability to loop all interfaces (based on ip link), this means we can run once for all interfaces. Signed-off-by: Richard Alpe <richard@bit42.se>
In "14128047e18d statd: remove nl code and improve speed" the handling of all interfaces where moved from statd to Yanger. This means statd no longer tracks interfaces using Netlink, but instead relies on Yanger to recognise and list all interfaces in the system. In the midst of this change the ignoring of "internal" interfaces where lost. In this commit we reintroduce this logic in Yanger and add a test case that ensures internal interfaces isn't listed. Fixes: 1412804 statd: remove nl code and improve speed Signed-off-by: Richard Alpe <richard@bit42.se>
rical
changed the title
13 tasks
rical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redesign how Yanger iterates interfaces and how it fetches ip data.
Run ip link and ip addr once and handle the interface selection in Yanger. This should be faster on systems with many ports and it simplifies the CLI test files.
Refactor (cleanup) unit test to fit the new way of looping interfaces from Yanger.
Hide internal interfaces in operational Yang data and CLI output. Add new test data to ensure this is tested by the unit-tests.
Other information
Checklist
Tick relevant boxes, this PR is-a or has-a: