Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container environment variables do not bite in container #822

Closed
troglobit opened this issue Nov 13, 2024 · 0 comments · Fixed by #826
Closed

Container environment variables do not bite in container #822

troglobit opened this issue Nov 13, 2024 · 0 comments · Fixed by #826
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troglobit
Copy link
Contributor

Current Behavior

When first adding environment variables to a container they show up:

admin@infix:/> configure 
admin@infix:/config/> edit container system 
admin@infix:/config/container/system/> set env FOO value bar
admin@infix:/config/container/system/> leave
admin@infix:/> container shell system 
root@sys0:/# set |grep FOO
FOO='bar'
root@sys0:/# 

However, changing the environment, or adding a new variable, does not "take" unless the container upgrade command is run:

admin@infix:/> configure 
admin@infix:/config/> set container system env FOO value "grok it"
admin@infix:/config/> leave
admin@infix:/> container shell system 
root@sys0:/# set |grep FOO
FOO='bar'
root@sys0:/# 
admin@infix:/> 
admin@infix:/> container upgrade system 
>> Stopping ... system
>> Trying to pull ghcr.io/kernelkit/curios:edge...
Getting image source signatures
Copying blob 15adbdbf57fc skipped: already exists  
Copying config 49639ab9de done  
Writing manifest to image destination
Storing signatures
49639ab9de610f4046b154d4d6313d7111f7d1f61f6efd5221a8f55b708c537d
>> Starting system ...
e2cadcd09f98a505056adf240d58e8f7b0becb6e116f727e81179c7ce88e668e
>> Done.
admin@infix:/> container shell system 
root@sys0:/# set |grep FOO
FOO='grok it'
root@sys0:/# 

Expected Behavior

Changes to a container's configuration should always be applied, and other changes to Infix running-config should not affect an already running container.

Steps To Reproduce

see above

Additional information

No response

@troglobit troglobit added bug Something isn't working triage Pending investigation & classification (CCB) and removed triage Pending investigation & classification (CCB) labels Nov 13, 2024
@troglobit troglobit self-assigned this Nov 13, 2024
@troglobit troglobit added this to the Infix v24.11 milestone Nov 13, 2024
@troglobit troglobit moved this to In progress in Infix & C:o Nov 13, 2024
troglobit added a commit that referenced this issue Nov 16, 2024
 - Reduce the amount of queues: 3 -> 1
 - Simplify post hook
 - Refine execd

The resulting simplification of infix_containers_post_hook(), and
touching execd, also ensure container environment variable changes
are propagated.

Fixes #822

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit mentioned this issue Nov 16, 2024
17 tasks
troglobit added a commit that referenced this issue Nov 18, 2024
 - Reduce the amount of queues: 3 -> 1
 - Simplify post hook
 - Refine execd

The resulting simplification of infix_containers_post_hook(), and
touching execd, also ensure container environment variable changes
are propagated.

Fixes #822

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Nov 20, 2024
 - Reduce the amount of queues: 3 -> 1
 - Simplify post hook
 - Refine execd

The resulting simplification of infix_containers_post_hook(), and
touching execd, also ensure container environment variable changes
are propagated.

Fixes #822

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@wkz wkz closed this as completed in #826 Nov 20, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infix & C:o Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant