Improved dehypenisation #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermitt2
approved these changes
Sep 28, 2019
| @@ -21,6 +22,9 @@ | |||
| */ | |||
| public class LayoutTokensUtil { | |||
|
|
|||
| private final static Pattern LOWERCASE_LETTERS = Pattern.compile("[a-z]+"); | |||
| private final static Pattern UPPER_AND_LOWERCASE_LETTERS = Pattern.compile("^[A-Za-z]+$"); | |||
|
|
|||
There was a problem hiding this comment.
Normally we should use Unicode character class (\p{Lu} for uppercase unicodes, \p{Ll} for lowercase unicodes) and methods like Character.isLowerCase(), because here we might miss many characters in non-English languages.
|
PDF Case of #180 is working fine and the PR is tested against the 1942 PMC PDF without loss, many thanks ! |
tantikristanti
pushed a commit
that referenced
this pull request
Nov 15, 2019
Improved dehypenisation Former-commit-id: 472324a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to improve the dehypenisation (#180)
Changes:
TODO?: use a dictionary to check whether
previousToken + followingTokenare valid words (from dehypeniseHard)/cc @de-code