Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect "other" text on request #1212

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Dec 22, 2024

This PR is a short term hacky fix for compensating having models that are slow to evolve.

This fix is disabled by default but is needed for indexing, so that we can guarantee that no text id dropped.

@coveralls
Copy link

coveralls commented Jan 4, 2025

Coverage Status

coverage: 40.329% (-0.06%) from 40.384%
when pulling 33187e2 on feature/collect-discarded-data
into 1021aba on master.

# Conflicts:
#	grobid-core/src/main/java/org/grobid/core/data/Figure.java
#	grobid-core/src/main/java/org/grobid/core/data/Table.java
#	grobid-core/src/main/java/org/grobid/core/document/TEIFormatter.java
#	grobid-core/src/main/java/org/grobid/core/engines/FullTextParser.java
@lfoppiano lfoppiano changed the title Collect "other" text from header Collect "other" text on request Jan 4, 2025
@lfoppiano lfoppiano marked this pull request as ready for review January 6, 2025 16:35
# Conflicts:
#	grobid-service/src/main/java/org/grobid/service/GrobidRestService.java
#	grobid-service/src/main/java/org/grobid/service/process/GrobidRestProcessFiles.java
# Conflicts:
#	grobid-core/src/main/java/org/grobid/core/data/BiblioItem.java
#	grobid-core/src/main/java/org/grobid/core/data/Figure.java
#	grobid-core/src/main/java/org/grobid/core/engines/HeaderParser.java
# Conflicts:
#	grobid-core/src/main/java/org/grobid/core/engines/Engine.java
#	grobid-service/src/main/java/org/grobid/service/GrobidRestService.java
#	grobid-service/src/main/java/org/grobid/service/process/GrobidRestProcessFiles.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants