Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IS_THREAD_SAFE backend flag #20383

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

nicolaspi
Copy link
Contributor

@nicolaspi nicolaspi commented Oct 19, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (813fbc5) to head (aa31f67).
Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (813fbc5) and HEAD (aa31f67). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (813fbc5) HEAD (aa31f67)
keras 4 3
keras-torch 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20383      +/-   ##
==========================================
- Coverage   78.87%   73.50%   -5.38%     
==========================================
  Files         512      513       +1     
  Lines       49266    49374     +108     
  Branches     7953     7962       +9     
==========================================
- Hits        38861    36294    -2567     
- Misses       8546    11279    +2733     
+ Partials     1859     1801      -58     
Flag Coverage Δ
keras 73.43% <92.30%> (-5.31%) ⬇️
keras-jax 62.49% <76.92%> (+0.09%) ⬆️
keras-numpy 57.55% <92.30%> (+0.13%) ⬆️
keras-tensorflow 63.64% <76.92%> (+<0.01%) ⬆️
keras-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaspi nicolaspi changed the title Force sync callbacks for tensorflow backend Added IS_THREAD_SAFE backend flag Oct 19, 2024
@nicolaspi
Copy link
Contributor Author

Relevant tensorflow issue: tensorflow/tensorflow#78338

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thank you for the fix.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 19, 2024
@fchollet
Copy link
Collaborator

Tests / Check the code format (pull_request) Failing after 2m

Please run sh shell/format.sh

@fchollet fchollet merged commit 8029c78 into keras-team:master Oct 19, 2024
4 of 7 checks passed
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low frequency issue using the tensorflow-GPU backend
5 participants