Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload cifar10 and cifar100 datasets #20185

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: upload cifar10 and cifar100 datasets #20185

merged 2 commits into from
Aug 29, 2024

Conversation

ghsanti
Copy link
Contributor

@ghsanti ghsanti commented Aug 29, 2024

The modifications to get_file, and removing the deprecated untar need an extra directory name to be accessed.
Other possible solutions were provided by myself an others in the linked Issue.

I did a demo here: Colab, also tested on Windows.

The commit that produced the issue seems to be this one.

Maybe @ashep29 or @mehtamansi29 have an opinion.

Note that it's just one commit, somehow VSCode managed to duplicate it.

Closes #20180

Copy link

google-cla bot commented Aug 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ghsanti
Copy link
Contributor Author

ghsanti commented Aug 29, 2024

i've signed cla already, idk why it fails.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (19ba3d1) to head (1fc5f38).
Report is 181 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/datasets/cifar10.py 0.00% 2 Missing ⚠️
keras/src/datasets/cifar100.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20185      +/-   ##
==========================================
- Coverage   79.37%   79.37%   -0.01%     
==========================================
  Files         501      501              
  Lines       47348    47350       +2     
  Branches     8695     8695              
==========================================
  Hits        37582    37582              
- Misses       8009     8011       +2     
  Partials     1757     1757              
Flag Coverage Δ
keras 79.22% <0.00%> (-0.01%) ⬇️
keras-jax 62.49% <0.00%> (-0.01%) ⬇️
keras-numpy 57.67% <0.00%> (-0.01%) ⬇️
keras-tensorflow 63.88% <0.00%> (-0.01%) ⬇️
keras-torch 62.54% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 29, 2024
@fchollet fchollet merged commit 4c71314 into keras-team:master Aug 29, 2024
9 of 10 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tf.keras.datasets.cifar10.load_data - FileNotFoundError: [Errno 2] No such file or directory
4 participants