Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat!: Reimplement service with go-sdk #351

Merged
merged 17 commits into from
Aug 31, 2022
Merged

feat!: Reimplement service with go-sdk #351

merged 17 commits into from
Aug 31, 2022

Conversation

TannerGabriel
Copy link
Member

@TannerGabriel TannerGabriel commented Aug 29, 2022 •
edited
Loading

This PR

  • Removes the distributor
  • Reimplements the service using the go-sdk instead of keptnutils
  • Update go-utils to version v0.18.0
  • Removes the useLocalFileSystem flag and functionality

Note: The TestJobExecutorServiceNoIngress integration test is suppose to fail and will be removed in another PR

@TannerGabriel
chore: Remove useLocalFileSystem implementation
35faf00 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Merge branch 'main' into chore/remove-use-local-file-system
cb091f8
@TannerGabriel
Implement main and event handler in go-sdk
aa0cd59 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Add go-sdk environment variables + Update code
0a1b731 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Start reimplementing unit tests
a29ae19 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Use go-utils APIV2
5d3f048 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
github-actions[bot]
github-actions bot reviewed Aug 29, 2022
View reviewed changes
cmd/job-executor-service/main.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service_test.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited
Loading

Test Results

131 tests   118 ✔️  2s ⏱️
  13 suites    13 💤
    1 files        0 ❌

Results for commit 0ebf3a9.

♻️ This comment has been updated with latest results.

@TannerGabriel
Add PUBSUB topic + Code quality changes
03a6906 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Change uniform subscription default value
61669c9 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Fix / escaping in GetAllKeptnResources
56ad486 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Add logging to tests
845c12b 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel TannerGabriel marked this pull request as ready for review August 30, 2022 08:50
Raffy23
Raffy23 reviewed Aug 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
cmd/job-executor-service-initcontainer/main.go Outdated Show resolved Hide resolved
cmd/job-executor-service-initcontainer/main.go Show resolved Hide resolved
pkg/eventhandler/eventhandlers_test.go Outdated Show resolved Hide resolved
pkg/file/file_test.go Outdated Show resolved Hide resolved
pkg/k8sutils/job.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
@TannerGabriel
Add mountFile unit tests + PR comments
2fa89cd 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel TannerGabriel changed the title feat: Reimplement service with go-sdk !feat: Reimplement service with go-sdk Aug 30, 2022
@TannerGabriel
Remove log statements
8637e78 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
Raffy23
Raffy23 reviewed Aug 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
pkg/eventhandler/eventhandlers.go Show resolved Hide resolved
@TannerGabriel
Convert eventhandler tests to go-sdk
9f42cee 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel TannerGabriel changed the title !feat: Reimplement service with go-sdk feat!: Reimplement service with go-sdk Aug 30, 2022
@TannerGabriel
Fix JobConfigReader creation in event handler
8042a26 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Add function documentation
0ebf3a9 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.2.6-dev-PR-351,keptncontrib/job-executor-service:0.2.6-dev-PR-351.202208310835
  • keptncontrib/job-executor-service-initcontainer:0.2.6-dev-PR-351,keptncontrib/job-executor-service-initcontainer:0.2.6-dev-PR-351.202208310835

Raffy23
Raffy23 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Raffy23 Raffy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TannerGabriel TannerGabriel merged commit 91c9409 into main Aug 31, 2022
@TannerGabriel TannerGabriel deleted the chore/remove-use-local-file-system branch August 31, 2022 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@christian-kreuzberger-dtx christian-kreuzberger-dtx christian-kreuzberger-dtx left review comments

@Raffy23 Raffy23 Raffy23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TannerGabriel @Raffy23 @christian-kreuzberger-dtx