Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use jsonpb.Marshaler instead of json.Marshal #190

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

slayerjain
Copy link
Member

The keploy go-sdk uses graph-curl internally, which uses jsonpb. In certain types like google.protobuf.Int32Value json.Marshall produces jsons in different format from what jsonpb expects. So we have switched to jsonpb to marshal too.

reported on slack support group here - https://keploy.slack.com/archives/C035URHSGDQ/p1682542804928449

Signed-off-by: Shubham Jain <shubhamkjain@outlook.com>
@slayerjain
Copy link
Member Author

This PR fixes keploy/keploy#546

@slayerjain slayerjain merged commit 640732a into main Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant