Fix UnsupportedOperationException from OperationBuilders #27
Conversation
When registering artifact repositories with an Operation Builder the user gets an UnsupportedOperationException if the builder is using default repositories. Furthermore, setting useDefaultRepositories causes any previously registered repositories to be lost. This should be fixed to ensure that no registered repositories are lost, and that default repositories are only used if enabled and not overriden in the builder. Signed-off-by: Tim Ward <timothyjward@apache.org>
|
@ideas-into-software - I bumped into this while writing my demo. I updated one of the integration tests to trigger the failure, then fixed it. The fix was small so hopefully is not disruptive. |
There was a problem hiding this comment.
This is how I understood specification for this particular part, i.e. if useDefaultRepositories is set to true - and by default, as per spec, this was supposed to be set to true - default repositories are to be used, which to me implied user will not be adding any other repositories, and only if useDefaultRepositories was set to false would custom repositories be added ( hence maybeResetDefaultRepositories method in FeatureRuntimeImpl, etc. ).
You know your intent much better than I do, but this is just to clarify my understanding of spec and why this was implemented this way - this understanding is also reflected in test cases defined in FeatureRuntimeIntegrationTest.
When registering artifact repositories with an Operation Builder the user gets an UnsupportedOperationException if the builder is using default repositories. Furthermore, setting useDefaultRepositories causes any previously registered repositories to be lost. This should be fixed to ensure that no registered repositories are lost, and that default repositories are only used if enabled and not overriden in the builder.