Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

Call given onClick when using getInputTogglerProps(props) & getElemen… #12

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

Andarist
Copy link
Collaborator

What:
Call given onClick when using getInputTogglerProps(props) & getElementTogglerProps(props)

Why:
This is a "bug fix" - if a click on both of those is supposed to call toggle then it should also call props.onClick

How:
Simple fix, im spreading props in both of those, so callAll can handle it in getTogglerProps.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #12   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          18     18           
  Branches        7      7           
=====================================
  Hits           18     18
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b1a56...75dc06f. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure how we missed that!

@kentcdodds kentcdodds merged commit 56b2430 into kentcdodds:master Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants