Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ESLint 7.x #64

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Conversation

MichaelDeBoey
Copy link
Collaborator

@MichaelDeBoey MichaelDeBoey commented May 8, 2020

ESLint v7.0.0 is released 🎉

(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:


BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thanks!

@MichaelDeBoey
Copy link
Collaborator Author

@kentcdodds It seems like kcd-scripts is taking the wrong eslint version (the one installed by kcd-scripts instead of by eslint-config-kentcdodds) to execute the lint script.

@kentcdodds
Copy link
Owner

There's a circular dependency. We'll need to update both. I don't mind if it's messed up for one release, so the order shouldn't matter.

@MichaelDeBoey
Copy link
Collaborator Author

MichaelDeBoey commented Sep 20, 2020

@kentcdodds Let's first update this one then 🙂

I still have another problem.
Due to the fact that all Node.js/CommonJS rules have been deprecated, I included eslint-plugin-node to replace them.
But this means I have to include all the following rules too:

node/exports-style                             node/file-extension-in-import                  node/no-callback-literal                       node/no-deprecated-api                         node/no-exports-assign
node/no-extraneous-import                      node/no-extraneous-require                     node/no-missing-import                         node/no-missing-require                        node/no-restricted-import
node/no-restricted-require                     node/no-unpublished-bin                        node/no-unpublished-import                     node/no-unpublished-require                    node/no-unsupported-features/es-builtins
node/no-unsupported-features/es-syntax         node/no-unsupported-features/node-builtins     node/prefer-global/buffer                      node/prefer-global/console                     node/prefer-global/process
node/prefer-global/text-decoder                node/prefer-global/text-encoder                node/prefer-global/url                         node/prefer-global/url-search-params           node/prefer-promises/dns
node/prefer-promises/fs                        node/process-exit-as-throw                     node/shebang

Should I include all node rules or just remove all Node.js/CommonJS rules? 🤔

@kentcdodds
Copy link
Owner

Let's go ahead and configure those rules 👍

BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks so much for all your work here!

@kentcdodds kentcdodds merged commit d41a11f into kentcdodds:master Sep 20, 2020
@MichaelDeBoey
Copy link
Collaborator Author

Always a pleasure to help out 🙂

@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch September 20, 2020 22:42
@MichaelDeBoey
Copy link
Collaborator Author

@kentcdodds Since CI is failing tests, this one won't be released either 😕
https://travis-ci.com/github/kentcdodds/eslint-config-kentcdodds/builds/185492446

@kentcdodds
Copy link
Owner

🎉 This PR is included in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants