Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages & add new rules #36

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Update packages & add new rules #36

merged 2 commits into from
Sep 9, 2019

Conversation

MichaelDeBoey
Copy link
Collaborator

This would be a breaking change, since facebook/react#16455

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not going to treat this as a breaking change because nobody has code that violates the rule anyway (it wouldn't work).

@kentcdodds kentcdodds merged commit 04236db into kentcdodds:master Sep 9, 2019
@MichaelDeBoey MichaelDeBoey deleted the update-deps branch September 9, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants