Bumping dependencies #77
Conversation
Play 2.6.19 Dropwizard 4.0.3 Scala 2.12.6
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 84.12% 84.12%
=======================================
Files 4 4
Lines 63 63
Branches 3 5 +2
=======================================
Hits 53 53
Misses 10 10
Continue to review full report at Codecov.
|
|
@liorhar Do you think we can merge this? I don't see why not. Thanks! |
|
Thanks for the contribution! I don't see a reason not to merge this, but I'm going to take a minute to go through the Dropwizard Metrics 4.0 release notes to see there are no (bad) surprises there. I'll also try testing this locally with a sample Play project. If all looks good, I'll merge. |
|
|
||
| //Test | ||
| "com.typesafe.play" %% "play-test" % playVersion % Test, | ||
| "com.typesafe.play" %% "play-specs2" % playVersion % Test |
| @@ -67,7 +68,7 @@ class MetricsImpl @Inject() (lifecycle: ApplicationLifecycle, configuration: Con | |||
| } | |||
| } | |||
|
|
|||
| def onStart() = { | |||
| def onStart(): ObjectMapper = { | |||
There was a problem hiding this comment.
It's not critical, but I think the return type here should be Unit - indeed the method's last expression has type ObjectMapper, but that's just coincidental, it wasn't supposed to be exposed (which just goes to show why public methods should have explicit return types, so thanks for that).
|
New version ( Thanks again @alejandrod! |
Play 2.6.19
Dropwizard 4.0.3
Scala 2.12.6