Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default on HostKeyCallback #2

Merged
merged 2 commits into from
Feb 6, 2018

Conversation

robermorales
Copy link
Contributor

Since this issue golang/go#19767 the default behaviour of HostKeyCallback changed, so the old behaviour can be achieved with this change.

Since this issue golang/go#19767 the default behaviour of HostKeyCallback changed, so the old behaviour can be achieved with this change.
Adding default on HostKeyCallback
@kennylevinsen kennylevinsen merged commit 6b6ca43 into kennylevinsen:master Feb 6, 2018
@kennylevinsen
Copy link
Owner

Thanks!

Your commit history is a little bit weird, as you're basically making a pull request out of a pull request. I fast-forward merged to avoid a history looking like: "Merge pull request #2: Merge pull request #1: Adding default on HostKeyCallback".

For future reference (not just for this project, but in general), I think it's best to only make pull requests on feature branches. That is, the branch you made a pull request with on your fork should just have been reused to make a pull request towards this upstream repo, rather than using master (which now contained a mege commit). That keeps the git commit history nice and clean.

@robermorales
Copy link
Contributor Author

Totally agree on the suggestion. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants