Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for installer #103

Merged
merged 1 commit into from
Mar 20, 2016
Merged

Improvements for installer #103

merged 1 commit into from
Mar 20, 2016

Conversation

bellflower2015
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c5d9a47 on bellflower2015:feature/application_name into * on kenjis:master*.

@kenjis
Copy link
Owner

kenjis commented Mar 19, 2016

Why do you need this change?

@bellflower2015
Copy link
Contributor Author

e.g., situations as following:

project/
|-- app_front/   (application A)
|   `-- public/   (docroot A)
|-- app_admin/   (application B)
|   `-- public/   (docroot B)
`-- vendor/   (composer autoload)

@kenjis kenjis merged commit c5d9a47 into kenjis:master Mar 20, 2016
@kenjis
Copy link
Owner

kenjis commented Mar 20, 2016

I see. I merged your PR.
Thanks!

@bellflower2015
Copy link
Contributor Author

Thanks a lot :)

@kenjis
Copy link
Owner

kenjis commented Mar 21, 2016

@bellflower2015 I've updated the installer in dev-master for CodeIgniter 3.0.6.
If you should have any problems, feel free to report it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bellflower2015 @coveralls @kenjis