Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Commit

Permalink
chore(radar_fusion_to_detected_object): fix TODO comments (autowarefo…
Browse files Browse the repository at this point in the history
…undation#1473)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
  • Loading branch information
kenji-miyake authored Aug 1, 2022
1 parent 2958bfa commit 28e8e30
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class RadarFusionToDetectedObject
Param param_{};
std::shared_ptr<std::vector<RadarInput>> filterRadarWithinObject(
const DetectedObject & object, const std::shared_ptr<std::vector<RadarInput>> & radars);
// [TODO] (Satoshi Tanaka) Implement
// TODO(Satoshi Tanaka): Implement
// std::vector<DetectedObject> splitObject(
// const DetectedObject & object, const std::shared_ptr<std::vector<RadarInput>> & radars);
TwistWithCovariance estimateTwist(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ RadarFusionToDetectedObject::Output RadarFusionToDetectedObject::update(
std::shared_ptr<std::vector<RadarInput>> radars_within_object =
filterRadarWithinObject(object, input.radars);

// [TODO] (Satoshi Tanaka) Implement
// TODO(Satoshi Tanaka): Implement
// Split the object going in a different direction
// std::vector<DetectedObject> split_objects = splitObject(object, radars_within_object);
std::vector<DetectedObject> split_objects;
Expand Down Expand Up @@ -165,7 +165,7 @@ RadarFusionToDetectedObject::filterRadarWithinObject(
return std::make_shared<std::vector<RadarFusionToDetectedObject::RadarInput>>(outputs);
}

// [TODO] (Satoshi Tanaka) Implementation
// TODO(Satoshi Tanaka): Implementation
// std::vector<DetectedObject> RadarFusionToDetectedObject::splitObject(
// const DetectedObject & object, const std::vector<RadarInput> & radars)
// {
Expand Down Expand Up @@ -257,7 +257,7 @@ TwistWithCovariance RadarFusionToDetectedObject::estimateTwist(
vec_target_value_average * param_.velocity_weight_target_value_average;
TwistWithCovariance estimated_twist_with_covariance = toTwistWithCovariance(sum_vec);

// [TODO] (Satoshi Tanaka) Implement
// TODO(Satoshi Tanaka): Implement
// Convert doppler velocity to twist
// if (param_.convert_doppler_to_twist) {
// twist_with_covariance = convertDopplerToTwist(object, twist_with_covariance);
Expand All @@ -280,7 +280,7 @@ bool RadarFusionToDetectedObject::isQualified(
}
}

// [TODO] (Satoshi Tanaka) Implement for radar pointcloud fusion
// TODO(Satoshi Tanaka): Implement for radar pointcloud fusion
// TwistWithCovariance RadarFusionToDetectedObject::convertDopplerToTwist(
// const DetectedObject & object, const TwistWithCovariance & twist_with_covariance)
// {
Expand Down

0 comments on commit 28e8e30

Please sign in to comment.