Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language switcher and PanelNavigation bug #44

Merged
merged 4 commits into from
May 1, 2024

Conversation

mansoorkhan96
Copy link
Contributor

@mansoorkhan96 mansoorkhan96 commented Apr 30, 2024

This PR fixes two bugs:

  • It fixes CanRegisterPanelNavigation to restrict access for LanguageLineResource for specified panels.
  • It updates language-switcher.blade.php to match the language switcher icon size with Filament and remove unnecessary margin left.

Filament already has `gap-x-4` on parent element. So it makes sense to remove it.
@mansoorkhan96 mansoorkhan96 changed the title Update language-switcher.blade.php Fix language switcher and PanelNavigation bug May 1, 2024
@Jehizkia Jehizkia added the bug Something isn't working label May 1, 2024
@Jehizkia Jehizkia self-requested a review May 1, 2024 07:25
@Jehizkia
Copy link
Member

Jehizkia commented May 1, 2024

Thank you!

@Jehizkia Jehizkia merged commit bcc7a64 into kenepa:4.x May 1, 2024
1 check failed
@mansoorkhan96 mansoorkhan96 deleted the patch-1 branch May 1, 2024 08:33
@mansoorkhan96
Copy link
Contributor Author

@Jehizkia Possible to tag a minor release?

@Jehizkia
Copy link
Member

Jehizkia commented May 1, 2024

Yes, I'll release it within an hour. Finishing up some other pending pr's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants