Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/normal reduce sum #1214

Merged
merged 12 commits into from
Jun 11, 2024
Merged

Fix/normal reduce sum #1214

merged 12 commits into from
Jun 11, 2024

Conversation

curioyang
Copy link
Member

fix normal reduce
pass opVersion arg into ReduceCore

Copy link

github-actions bot commented May 28, 2024

Test Results

6 081 tests  +144   6 081 ✅ +144   8m 26s ⏱️ -10s
    6 suites ±  0       0 💤 ±  0 
    6 files   ±  0       0 ❌ ±  0 

Results for commit 1328648. ± Comparison against base commit 6a4b1f6.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.20%. Comparing base (a13d43d) to head (647e75e).
Report is 10 commits behind head on master.

Current head 647e75e differs from pull request most recent head 1328648

Please upload reports for the commit 1328648 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
- Coverage   73.26%   73.20%   -0.06%     
==========================================
  Files         706      706              
  Lines       25960    26018      +58     
  Branches     4229     4233       +4     
==========================================
+ Hits        19020    19047      +27     
- Misses       6294     6326      +32     
+ Partials      646      645       -1     
Flag Coverage Δ
integration 39.28% <100.00%> (-0.04%) ⬇️
unit 64.62% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curioyang curioyang closed this Jun 7, 2024
@curioyang curioyang reopened this Jun 7, 2024
@curioyang curioyang merged commit 0a8ccc1 into master Jun 11, 2024
42 checks passed
@curioyang curioyang deleted the fix/normal_reduce_sum branch June 11, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants