Apply syntax changes proposed in whatwg/urlpattern#198. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kenchris This pull request implements upstream changes in whatwg/urlpattern#198 and recently landed in Chromium https://chromium-review.googlesource.com/c/chromium/src/+/4975595. I don't know when you would like to incorporate parallel changes to the polyfill (I don't expect to need to roll back this change, but it's always possible), but this PR hopefully makes it easy to do so when you feel it's appropriate. |
|
When is this being released in stable Chrome? We should probably release a version shortly after. |
|
If all goes to plan, it'll ship with Chrome 121, which will reach stable channel around Tue Jan 23 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the spec changes closely, and includes the updated tests, copied from the Chromium CL which implements it.
Fixes #122.