Improve type safety of URLPattern args #105
Open
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenchris
reviewed
Nov 15, 2022
| @@ -1,11 +1,11 @@ | |||
| export type URLPatternInput = URLPatternInit | string; | |||
| export type URLPatternArgs = | |||
There was a problem hiding this comment.
Could we keep the name URLPatternInput to follow the spec?
|
@SanderElias can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the types closer to the behavior of the polyfill and the Chrome implementation by using a discriminated union to determine if the second arg is allowed, and then sharing the args between methods in a tuple type.
Note that this is a breaking change for TypeScript users, as I wanted to get rid of
URLPatternInputto improve type safety. If possible, I'd recommend a major release for this.