Remove Buffer cast method #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer objects should never be cloned because it will result in double free when the objects are dropped.
Buffer PhantomData type field does not need to be interacted with, thus remove unnecessary pub modifier.
kenba
approved these changes
Jan 16, 2021
|
It may be possible to avoid the double free by calling Please, in future can you raise items as issues instead of pull requests? |
|
Okay, will go the issue way in future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer objects should actually never be cloned because it will result in double free when the original and typecasted Buffer objects are dropped. Pardon for this bug introduced in my previous pull request.
A better way is to cast the data of another type to correct type before writing to a Buffer, and when reading, doing the type cast after reading from the Buffer to result array. This should also be more explicit in the code.