Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mutability explicit #27

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Make mutability explicit #27

merged 1 commit into from
Aug 13, 2021

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Aug 11, 2021

When a cl_mem is passed around, sometimes a mutable reference is needed.
Add a get_mut() method to the ClMem trait, so that the mutability
requirements automatically bubble up the API.

Closes #26.

@vmx vmx changed the base branch from main to develop August 11, 2021 09:27
When a `cl_mem` is passed around, sometimes a mutable reference is needed.
Add a `get_mut()` method to the `ClMem` trait, so that the mutability
requirements automatically bubble up the API.

Closes kenba#26.
@vmx
Copy link
Contributor Author

vmx commented Aug 11, 2021

I did a force-push as the original commit was against main and not develop.

Copy link
Owner

@kenba kenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kenba kenba merged commit f55c841 into kenba:develop Aug 13, 2021
@vmx vmx mentioned this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should CommandQueue.html::enqueue_write_buffer take a mutable buffer reference?
2 participants