-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bool
instead of cl_bool
#24
Comments
Yes Volker, I agree that the calls that return Please feel free to implement the change in a PR again. However, please use As for the change breaking the API, it's not a problem I'll simply release the change under version '0.3.0'. |
I'm not only talking about returns, but also input values, e.g. in Finding all functions that return a
Yes, what I meant was, that I wanted to do all those changes before doing a 0.3 release and not getting a 0.3 out and then doing changes we already know that will need a 0.4. |
On searching for The The As for all functions that return a |
Thanks for the detailed analysis. I actually sue I currently don't have the need for having all functions return Rust |
Also add `Sampler` methods for `get_sampler_info`.
When you search the
opencl3
source code forcl_bool
, you find some occurrences in the public API. I propose changing them to a Rustbool
type.cl_bool
is a type alias foru32
, so you need to use in0
and1
(or use theCL_FALSE
/CL_TRUE
constants), and cannot just usetrue
orfalse
, which I'd find more ergonomic.I bring it up as #22 is a breaking change, so it might be the right time to do more related breaking changes like this one.
The text was updated successfully, but these errors were encountered: