Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Debug derives #14

Closed
vmx opened this issue May 20, 2021 · 2 comments
Closed

Adding Debug derives #14

vmx opened this issue May 20, 2021 · 2 comments

Comments

@vmx
Copy link
Contributor

vmx commented May 20, 2021

As there will be a new release soon, I thought it's the right to bring up another thing.

It would be great if there could be Debug implementations for the types. I guess for most of them a #[derive(Debug)] is good enough. It's useful e.g. if you've several buffers and want to distinguish them during debugging. Though I'd actually need it for my code base for ExecuteKernel and CommandQueue.

As always I'd be happy to provide a pull request if that helps.

kenba added a commit that referenced this issue May 20, 2021
@kenba
Copy link
Owner

kenba commented May 20, 2021

Another good one @vmx. I've added #[derive(Debug)] to all the types that didn't have Debug implementations including ExecuteKernel and CommandQueue. The changes are in the develop branch.

Please provide a pull request if the changes do not meet your needs and feel free to raise any other issues you have with the library.

@vmx
Copy link
Contributor Author

vmx commented May 25, 2021

I haven't had a closer look at your changes, but for my use case I was able to derive the Debug from the types that I've used. Thanks!

@vmx vmx closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants