Add InfoType::to_string method #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new InfoType::to_string method converts an OpenCL C string into Rust String using the `from_utf8_lossy` method to convert invalid characters to std::char::REPLACEMENT_CHARACTER. It is intended to replace `InfoType::to_str` which is now marked with the deprecated attribute.
vmx
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Cool, I find that this makes the API nicer to use.
On a more general note (this would be another PR), I think the conversion methods should for InfoType should be implemented as https://doc.rust-lang.org/std/convert/trait.TryFrom.html implementations. I bring it up, as this PR already deprecates things and I want to prevent that new additions are deprecated soon after they got introduced (in case moving to TryFrom is something desirable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
InfoType::to_strmethod converts an OpenCL C string into a Result containing a Rustffi::CStringand aNulError.The
InfoType::to_strmethod now handles null characters in OpenCL C strings returned from some devices, see issue #2.The new InfoType::to_string method converts an OpenCL C string into Rust String using the
from_utf8_lossymethod to convert invalid characters to std::char::REPLACEMENT_CHARACTER. It is intended to replaceInfoType::to_strwhich is now marked with the deprecated attribute.This change replaces all instances of
InfoType::to_strin this library withInfoType::to_string.