Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use From trait for `conversions #12

Closed
kenba opened this issue Sep 22, 2021 · 1 comment
Closed

Use From trait for `conversions #12

kenba opened this issue Sep 22, 2021 · 1 comment
Assignees
@kenba
Labels
enhancement New feature or request

Comments

@kenba
Copy link
Owner

kenba commented Sep 22, 2021

Following on from issue #11. It is probably better (i.e. more idiomatic) to perform all the conversions from InfoType into Rust types using the From trait instead of the to_* methods.
@kenba kenba added the enhancement New feature or request label Sep 22, 2021
@kenba kenba self-assigned this Sep 22, 2021
kenba added a commit that referenced this issue Sep 22, 2021
@kenba
Add From traits for issue #12
a655ec7
kenba added a commit that referenced this issue Oct 2, 2021
@kenba
Document changes for issues #11 & #12
3b1bc2f
@kenba
Copy link
Owner Author

kenba commented Oct 2, 2021

Implemented in version 0.5.0.

@kenba kenba closed this as completed Oct 2, 2021
@kenba kenba mentioned this issue Oct 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenba kenba

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenba