Support attrs on empty store

keller-mark · May 7, 2024 · b099b98 · b099b98
1 parent 796018a
commit b099b98
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/R/attributes.R b/R/attributes.R
@@ -14,7 +14,7 @@ Attributes <- R6::R6Class("Attributes",
     cached_aslist = NULL,
 
     get_nosync = function() {
-
+      
     }
   ),
   public = list(
@@ -44,7 +44,15 @@ Attributes <- R6::R6Class("Attributes",
       self$synchronizer <- synchronizer
     },
     to_list = function() {
-      return(self$store$metadata_class$decode_metadata(self$store$get_item(self$key)))
+      attrs_list <- tryCatch({
+        return(self$store$metadata_class$decode_metadata(self$store$get_item(self$key)))
+      }, error = function(cond) {
+        if(is_key_error(cond)) {
+          return(obj_list())
+        }
+        stop(cond)
+      })
+      return(attrs_list)
     },
     refresh = function() {
       # TODO

diff --git a/tests/testthat/test-attrs.R b/tests/testthat/test-attrs.R
@@ -0,0 +1,8 @@
+library(pizzarr)
+
+test_that("Can get attributes for empty store (without throwing a KeyError)", {
+    store <- MemoryStore$new()
+    g <- zarr_open_group(store)
+
+    expect_equal(g$get_attrs()$to_list(), obj_list())
+})