Fix guess_chunks to prevent infinite loop (#92)

keller-mark · Jun 20, 2024 · 0825c03 · 0825c03
1 parent 3bf3ce4
commit 0825c03
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/R/normalize.R b/R/normalize.R
@@ -180,7 +180,7 @@ guess_chunks <- function(shape, typesize) {
         break  # Element size larger than CHUNK_MAX
       }
 
-      chunks[idx %% ndims] <- ceiling(chunks[idx %% ndims] / 2.0)
+      chunks[idx %% ndims + 1] <- ceiling(chunks[idx %% ndims + 1] / 2.0)
       idx <- idx + 1
   }
 

diff --git a/tests/testthat/test-chunks.R b/tests/testthat/test-chunks.R
@@ -1,5 +1,18 @@
 library(pizzarr)
 
+test_that("no infinite loop", {
+    shape <- c(27557749)
+    dtype <- "<i4"
+    chunks <- NA
+
+    dtype <- normalize_dtype(dtype, object_codec = NA)
+    shape <- normalize_shape(shape)
+
+    dtype_itemsize <- dtype$num_bytes
+    chunks <- normalize_chunks(chunks, shape, dtype_itemsize)
+    expect_equal(chunks, c(215295))
+})
+
 test_that("can get array that spans multiple chunks", {
     a <- array(data=1:100, dim=c(10, 10))
     #      [,1] [,2] [,3] [,4] [,5] [,6] [,7] [,8] [,9] [,10]