-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Refactoring #78
Merged
Merged
CLI Refactoring #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to separate non-command-line interface from the CLI that would allow true modularity later on. Perhaps anything under interface could be made available under an API of the module or a Web Interface. CLI will access/require this through individual commands.
The new structure introduces a Command class and recursively requires and facilitates Command to each file under `cli\commands`
Let there be light.
This just plums in a empty db:seed command that simply fires the callback. I am adding this now so as we sort the cleanest way to do pathing, etc we can lay the base work so that keith can add the see implementation on top
…cture # Conflicts: # cli/cli.js
* Update task runner (and secheduler) to pass argv as second param to a task exec() * Update generator to not extend Nodal.SchedulerTask by default * Update generator to append `_task` to the file generated since the path sets the context it's a task
`access_token` and `user` are built in so they are direct and there is no need to wrap them around `<>`
…into CLI_restructure
…into CLI_restructure
A README on how to create and use CLI commands.
…into CLI_restructure
👍 Great work guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request includes recent structural changes to the command-line interface.
The new CLI now is implemented with a class-based structure that allows for better modularity. Changes include a revamp to the CLI output, better error handling, and CLI fixes for Windows.
Closes:
#76 #73 #70 #64
Notes:
db
&generate
have been moved underinterface
.