Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Refactoring #78

Merged
merged 42 commits into from
Jan 12, 2016
Merged

CLI Refactoring #78

merged 42 commits into from
Jan 12, 2016

Conversation

schahriar
Copy link
Contributor

This Pull Request includes recent structural changes to the command-line interface.

The new CLI now is implemented with a class-based structure that allows for better modularity. Changes include a revamp to the CLI output, better error handling, and CLI fixes for Windows.

Closes:
#76 #73 #70 #64

Notes:

  • Folders db & generate have been moved under interface.
  • Connected implementation to the CLI commands shouldn't throw and instead pass any errors to the callback. (see CLI Refactoring #64 for more information)

schahriar and others added 30 commits January 10, 2016 17:45
This is to separate non-command-line interface from the CLI that would
allow true modularity later on. Perhaps anything under interface could
be made available under an API of the module or a Web Interface. CLI
will access/require this through individual commands.
The new structure introduces a Command class and recursively requires
and facilitates Command to each file under `cli\commands`
This just plums in a empty db:seed command that simply fires the callback. I am adding this now so as we sort the cleanest way to do pathing, etc we can lay the base work so that keith can add the see implementation on top
* Update task runner (and secheduler) to pass argv as second param to a task exec()
* Update generator to not extend Nodal.SchedulerTask by default
* Update generator to append `_task` to the file generated since the path sets the context it's a task
`access_token` and `user` are built in so they are direct and there is
no need to wrap them around `<>`
@keithwhor
Copy link
Owner

👍 Great work guys.

keithwhor added a commit that referenced this pull request Jan 12, 2016
@keithwhor keithwhor merged commit 45990c4 into keithwhor:master Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants