Port the script to POSIX shell #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keis
reviewed
Nov 19, 2024
|
On Tue Nov 19, 2024 at 1:10 AM CET, David Keijser wrote:
We can probably forget about git 1.8 support at this point and go back to --invert-grep which I hope would avoid this temp file stuff
Ref https://github.com/keis/git-fixup/pull/34/files
Wow, it was me? ;) Yeah, git-fixup(1) is expected to be used only by developers and they shouldn’t use crazily old junk (if my git-log-foo is correct it was introduced in 2.4.0; the oldest versions of git I found on the enterprise distros with regular (non-extended) support is 2.31.1 on RHEL-8 and 2.16.3 on older version of SLE-15, 2.35.3 on the latest service pack).
I'm of half a mind to remove the fallback menu already and just have a message to configure fzf (or something like it) if a menu is desired. It adds a lot of noise to the script and even more in good ol' posix shell.
I have already ported it, so it should work, and moreover I am a little bit worried what crazy platforms git supports (fzf requires Golang, doesn’t it? so, how is Go on AIX, IRIX, Solaris 10, or OpenBSD? I have no clue), so I would rather keep `fallback_menu` around until it would be really burdensome to do so.
|
Absolutely! |
mcepl
force-pushed
the
posix
branch
7 times, most recently
from
ed42294 to
11301c0
Compare
And a snippet to Makefile to generate HTML and manpage.
The tests won't work outside of the git tree. Perhaps, I should just rewrite it to plain shell script. Should I?
keis
reviewed
Nov 30, 2024
| export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME | ||
|
|
||
| TEST_PASSES_SANITIZE_LEAK=true | ||
| . ./test-lib.sh |
There was a problem hiding this comment.
I found this https://github.com/felipec/sharness
Replacing test-lib with sharness I'm able to run this test
|
On Sat Nov 30, 2024 at 7:14 PM CET, David Keijser wrote:
I found this https://github.com/felipec/sharness
Replacing test-lib with sharness I'm able to run this test
I am developing completely in git proper
https://git.cepl.eu/cgit/git/git/log/?h=fixup and when I will be
done, I will post result to your PR (although, the question is
whether your project will be still relevant).
Best,
Matěj
…--
http://matej.ceplovi.cz/blog/, @***@***.***
GPG Finger: 3C76 A027 CA45 AD70 98B5 BC1D 7920 5802 880B C9D8
Why should I travel, when I’m already there?
-- Bostonian lady, when being asked why she never visited
other places than Boston
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to contribute this script to the git proper (unless you want to do it yourself), because it is nice to share, but for that to happen, the script must be ported to the POSIX shell (plus tests, man page, etc. must be added). This is my effort, any review would be welcome.