feat: refactor (#7)

kehiy · Jul 2, 2023 · 75db556 · 75db556
1 parent ffc6d05
commit 75db556
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/cmd/main.go → main.go b/cmd/main.go → main.go
diff --git a/pkg/resolver.go b/pkg/resolver.go
@@ -53,10 +53,9 @@ func handlePacket(pc net.PacketConn, addr net.Addr, buf []byte) error {
 }
 
 func dnsQuery(servers []net.IP, question dnsmessage.Question) (*dnsmessage.Message, error) {
-
 	for i := 0; i < 3; i++ {
 
-		dnsAnswer, header, err := outgoingDnsQuery(servers, question)
+		dnsAnswer, header, err := outgoingDNSQuery(servers, question)
 		if err != nil {
 			return nil, err
 		}
@@ -137,8 +136,8 @@ func dnsQuery(servers []net.IP, question dnsmessage.Question) (*dnsmessage.Messa
 	}, nil
 }
 
-func outgoingDnsQuery(servers []net.IP, question dnsmessage.Question) (*dnsmessage.Parser, *dnsmessage.Header, error) {
-	max := uint16(^uint16(0))
+func outgoingDNSQuery(servers []net.IP, question dnsmessage.Question) (*dnsmessage.Parser, *dnsmessage.Header, error) {
+	max := ^uint16(0)
 
 	// generate a random number max to unit16
 	randomNumber, err := rand.Int(rand.Reader, big.NewInt(int64(max)))

diff --git a/pkg/resolver_test.go b/pkg/resolver_test.go
@@ -85,7 +85,7 @@ func TestOutgoingDnsQuery(t *testing.T) {
 		t.Fatalf("No root servers found")
 	}
 	servers := []net.IP{net.ParseIP(rootServers[0])}
-	dnsAnswer, header, err := outgoingDnsQuery(servers, question)
+	dnsAnswer, header, err := outgoingDNSQuery(servers, question)
 	if err != nil {
 		t.Fatalf("outgoingDnsQuery error: %s", err)
 	}
@@ -96,7 +96,7 @@ func TestOutgoingDnsQuery(t *testing.T) {
 		t.Fatalf("no answer found")
 	}
 	if header.RCode != dnsmessage.RCodeSuccess {
-		t.Fatalf("response was not succesful (maybe the DNS server has changed?)")
+		t.Fatalf("response was not successful (maybe the DNS server has changed?)")
 	}
 	err = dnsAnswer.SkipAllAnswers()
 	if err != nil {